hi guys
sorry for the delay but ive finely had a look at the the knocking strut and found that the coil spring was not located in the top cup ( half of the top coil was hanging out), so it must have been like this for quite a while
thank god its all sorted know
mark