The front upper shock mounts shouldn't really knock when driving.

I would check the anti roll bar links and bushes.