We've been several times. All different parts. We've just come back from Makadi Bay (near Hurghada) and the hotel was fantastic. Highly recommend. If you have some time to spare, read my review on Tripadvisor, it's a bit of a long read though!!.....
http://www.tripadvisor.com/ShowUserR...and_Sinai.html
My only real serious piece of advice is to watch out for resorts with lots of Italians. I'm sure there are some people on here with Italian blood that may be offended by my remarks, but my experience of them in Egypt is that they are the rudest cunts I have ever met.