Most phones will do all that these days tbh. But if you are going for a contract and want a recommendation then the Sony Ericcson W810i is excellent. Got the Walkman mp3 player built in on top of 2MP camera and the usual.

One to avoid by all accounts is the Nokia N70